Always use smallest offset for new partitionGroups #8053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8053 +/- ##
============================================
+ Coverage 71.41% 71.43% +0.01%
- Complexity 4261 4262 +1
============================================
Files 1599 1599
Lines 83075 83074 -1
Branches 12402 12401 -1
============================================
+ Hits 59330 59341 +11
+ Misses 19722 19715 -7
+ Partials 4023 4018 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
LGTM. Let wait for @mcvsubbu to see if he has other comments
|
Need to merge this, already have two users in OSS waiting for this. If there's any concerns, will address separately in follow-ups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in issue #8052
Reverting the code from PR #7756 and using code from the alternative that was done earlier #7743
@KKcorps is working on enhancing the KinesisIntegrationTest